MINOR: Update inlined parquet.thrift to parquet-format 2.14.0 - #3791
Merged
Fokko merged 1 commit intoSep 14, 2026
Merged
Conversation
Brings the IDL up from 2.13.0, picking up the FILE logical type, INT96 chronological ordering and the ALP encoding. FILE now exists in the LogicalType union, so the converter would have thrown on it instead of falling into the unrecognised-type branch that ignores it. It is ignored explicitly now, keeping the physical type as before. ALP is in the format enum but has no Java implementation yet, so testEnumEquivalence skips it until one lands.
wgtmac
approved these changes
Sep 13, 2026
RussellSpitzer
approved these changes
Sep 14, 2026
divjotarora
approved these changes
Sep 14, 2026
Fokko
approved these changes
Sep 14, 2026
Fokko
left a comment
Fokko
left a comment
Contributor
There was a problem hiding this comment.
Thanks @vinooganesh for bumping this 👍
Contributor
|
Thanks @wgtmac @RussellSpitzer and @divjotarora for the quick review 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the inlined
parquet.thriftup from parquet-format 2.13.0 to 2.14.0, viadev/update-parquet-thrift.sh apache-parquet-format-2.14.0. The file is byte-identical to upstream at that tag, and the sidecar is repinned accordingly.That picks up three format additions: the FILE logical type, INT96 chronological ordering, and the ALP encoding.
Two small Java changes come with it:
FILEnow exists in theLogicalTypeunion. Before the bump a file using it fell into the unrecognised-logical-type branch and was ignored, preserving the physical type; afterwards it was a recognised member with no case and would have thrown. It is now ignored explicitly, so reader behaviour is unchanged. Covered by a test.ALPis in the format enum but has noorg.apache.parquet.column.Encodingcounterpart yet, sotestEnumEquivalencehas nothing to round trip it through. It skips ALP for now. The skip is temporary and is removed by Parquet Java ALP Implementation #3397, which adds the Java side.No behaviour changes otherwise. Full parquet-hadoop suite passes (746 tests), clean build, RAT and spotless clean.
@RussellSpitzer this is the precursor you asked for on #3397, so that the ALP entry comes from upstream rather than being a local addition. It turned out it cannot be thrift only: bumping on a clean master fails
testEnumEquivalencewithNo enum constant org.apache.parquet.column.Encoding.ALP, because the generated enum gains ALP(10) while the hand written one has none, and adding that constant pulls in the ALP readers. Hence the temporary skip here, which #3397 removes along with the local block.