[format] Reject multi-character csv delimiter, quote and escape - #9904
Merged
Merged
Conversation
Contributor
|
The premise checks out: The test covers both a multi-char value and the empty string, and the docs are updated consistently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
CsvParserkeeps onlycharAt(0)ofcsv.field-delimiter,csv.quote-characterandcsv.escape-character, while the writer emits the whole string. A multi-character value was accepted at DDL and then split on its first character only, so column boundaries silently disagreed with what had been written; an empty value threwStringIndexOutOfBoundsExceptionon read.fileformat.md:152has documentedmust be single characterfor the field delimiter since it was introduced; this enforces it where it is read and adds the note for quote and escape.csv.line-delimiteris not restricted —CustomLineReadermatches all of its bytes.This gates the Paimon implementation only;
format-table.implementation=enginenever constructsCsvOptions, and the implementation-independent check belongs invalidateFormatTableOptions(#8328).Tests
CsvFileFormatTest#testSingleCharacterOptionsAreEnforced. Reverting the fix:paimon-format: 634 run, 0 failures.Written with Claude Code; verification is mine.