[format] Close the codec probe stream in HadoopCompressionUtils - #9902
Merged
Merged
Conversation
Contributor
|
Good catch. Dropping the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
getCompressionCodecByCompressionprobes the codec by opening an output stream and discards it unclosed. Hadoop leases aCompressorfromCodecPoolfor that stream and returns it only onclose(), so every call orphaned one lease — once per data file, so a long-lived csv/json/text writer leaks steadily. A native compressor also keeps itsz_stream, released only viaend(). The probe is kept; it surfaces a missing native library at selection time.AbstractTextFileWriter.close()also drops a redundantflush():close()already flushes, and sinceSingleFileWritercloses writer and stream separately, a throwingflush()lost the lease for good.Tests
HadoopCompressionUtilsTest#testCodecProbeDoesNotLeaseACompressorasserts the leased count does not grow.DEFLATE, sinceGzipCodec.getCompressorType()is null without native zlib. Reverting the fix:paimon-format: 634 run, 0 failures.Written with Claude Code; verification is mine.