[core] Prune manifest blocks with sidecars during scans - #9897
Open
leaves12138 wants to merge 4 commits into
Open
leaves12138 wants to merge 4 commits into
leaves12138 wants to merge 4 commits into
Conversation
leaves12138
marked this pull request as ready for review
September 16, 2026 14:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Wire manifest sidecars into Java scans, following the format (#9845), lifecycle (#9886), and writer (#9889) changes. Extracted from #9743 after rebasing the tracking PR onto current master.
manifest.sidecar.enabled; no additional read option is introduced.ManifestFile.readoverloads for callers that do not supply a block selection.No file-format, writer, lifecycle or Python changes are included.
Tests
Java 8: 195 targeted tests passed with Checkstyle and Spotless enabled.
Tests cover row-ID, partition-only and bucket-only pruning; nullable coverage; real seek/byte-read accounting; repeated partial/all-block cache reads; explicit/custom references; disabled and unfiltered reads; missing/corrupt sidecar fallback while preserving deletes and overlapping row-ID groups; and existing data-evolution, bucket-filter, primary-key and global-index scans.
mvn -B -ntp -nsu -pl paimon-core -am -DwildcardSuites=none -DfailIfNoTests=false -Dflink.forkCount=2 \ -Dtest=ManifestFileTest,ManifestSidecarTest,ManifestSidecarWriteTest,ManifestBlockIndexTest,DataEvolutionFileStoreScanTest,BucketFilterScanTest,KeyValueFileStoreScanTest,DataEvolutionBatchScanTest test