[flink][cdc][iceberg] Include table identifier in schema-change and CDC-commit exception messages - #9892
Merged
JingsongLi merged 1 commit intoSep 17, 2026
Conversation
JTaky
force-pushed
the
oleksandr.nitavskyi/schema-change-exception-table-name
branch
from
September 16, 2026 11:12
cadea81 to
828d176
Compare
JTaky
force-pushed
the
oleksandr.nitavskyi/schema-change-exception-table-name
branch
from
September 16, 2026 11:40
828d176 to
23dc12c
Compare
…DC-commit exception messages UpdatedDataFieldsProcessFunctionBase.applySchemaChange and several other exceptions in the multi-table CDC sink and Iceberg-REST metadata-commit paths were thrown without the table identifier, even though it (or a FileStoreTable/Identifier reference) was already in scope. In a multi-table CDC sink processing many tables through shared operators, this made it impossible to tell which table caused a crash from the exception message alone, significantly slowing diagnosis during a live production incident. This appends the table identifier to each affected message. All changes are purely additive (same exception type, same trigger conditions, message text only) with no control-flow or method-signature changes.
JTaky
force-pushed
the
oleksandr.nitavskyi/schema-change-exception-table-name
branch
from
September 16, 2026 11:42
23dc12c to
9c4e3b1
Compare
JTaky
marked this pull request as ready for review
September 16, 2026 17:06
Contributor
|
All good — these context-free exceptions are painful to attribute in multi-table CDC jobs, and adding the table name at each site is low-risk and clearly useful. One small thing while you are touching the lines: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
UpdatedDataFieldsProcessFunctionBase.applySchemaChange and several other exceptions in the multi-table CDC sink and Iceberg-REST metadata-commit paths were thrown without the table identifier, even though it (or a FileStoreTable/Identifier reference) was already in scope.
In a multi-table CDC sink processing many tables through shared operators, this made it complicated to tell which table caused a crash from the exception message alone, which significantly slowed diagnosis during a live production incident.
This PR appends the table identifier to each affected message. All changes are purely additive (same exception type, same trigger conditions, message text only) with no control-flow or method-signature changes.
Tests
None added — this is a message-text-only change with no behavior change; existing tests continue to cover the trigger conditions unchanged.