Conversation
Honor snapshot.ignore-empty-commit=false so an empty table can be versioned with a tag. Preserve default empty-append skipping and no-op overwrite/drop behavior. Validation: real empty-tag readback and commit/callback/overwrite tests. Co-Authored-By: Codex <noreply@anthropic.com> AI-Model: gpt-6 Co-Authored-By: Codex <noreply@ai-tool.com> AI-Contributed/Feature: 32/32 AI-Contributed/UT: 47/47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
PyPaimon skips an append commit with no committables even when
snapshot.ignore-empty-commit=false. A newly created empty table therefore has no snapshot and cannot be tagged, preventing applications from pinning an empty component alongside populated tables.Honor the existing option for Python append commits. The default still skips empty appends; explicitly setting it to
falsecreates a normal snapshot that can be tagged and read. No-op overwrite/drop behavior is unchanged.Tests
table_commit_test.py,file_store_commit_test.py,write/commit_callback_test.py,overwrite_commit_conflict_test.py, andoverwrite_changes_cache_test.py(Python 3.13, PyArrow 19.0.1).git diff --checkpassed.