Repository navigation
[python] Use native primary-key full-text search - #10586
Merged
JingsongLi merged 1 commit intoOct 15, 2026
Merged
Conversation
leaves12138
approved these changes
Oct 15, 2026
leaves12138
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the native primary-key full-text path against the Java implementation and the merged Rust dependency (#1132). The Python changes correctly preserve FAST-only behavior, snapshot-scoped physical positions, deletion vectors, serialized splits, score ordering, and the shared PK result conversion. No blocking code issues found. The failing Native CI was built before Rust #1132 reached main, and the Python 3.6 failure is an unrelated Debian archive dependency 404.
JingsongLi
marked this pull request as ready for review
October 15, 2026 10:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Enable Native execution for the primary-key full-text searches already supported by PyPaimon, using Java's physical-position result semantics.
Depends on apache/paimon-rust#1132 reaching Rust main. Native CI continues to build main; keep this PR draft until the dependency merges.
Changes
execute_local()calls to Rust core, retaining the existing FAST-only contract and propagating execution errors without a Python retry.repr(tuple(...))form disagreed with both Java and Rust and changed the cross-partition tie breaker. No compatibility path is retained.Verification
The production adapter changes remain small; the query implementation is in the companion Rust core PR.