Repository navigation
[python] Align empty and metadata-only results with runtime read schemas - #10578
Merged
Merged
Conversation
…schemas Use the core read schema for Ray empty results and metadata-only search results. Keep read expectations separate from logical write constraints and preserve strict value, schema, and invalid-NULL checks. Co-Authored-By: Codex <noreply@anthropic.com> AI-Model: gpt-6 Co-Authored-By: Codex <noreply@ai-tool.com> AI-Contributed/Feature: 14/14 AI-Contributed/UT: 202/202
Exercise the core schema boundary without requiring a new native wheel. The test rejects the previous hard-coded non-nullable metadata field. Co-Authored-By: Codex <noreply@anthropic.com> AI-Model: gpt-6 Co-Authored-By: Codex <noreply@ai-tool.com> AI-Contributed/Feature: 0/0 AI-Contributed/UT: 11/11
Match the Arrow ListArray Non-nullable diagnostic while preserving the ValueError and invalid-NULL write checks. Co-Authored-By: Codex <noreply@anthropic.com> AI-Model: gpt-6 Co-Authored-By: Codex <noreply@ai-tool.com> AI-Contributed/Feature: 0/0 AI-Contributed/UT: 2/2
Reuse the existing Ray and search schema regressions and remove redundant schema assertions. Normalize the BinaryRow read fixture after setup writes so individual tests keep their original strict comparisons. Co-Authored-By: Codex <noreply@anthropic.com> AI-Model: gpt-6 Co-Authored-By: Codex <noreply@ai-tool.com> AI-Contributed/Feature: 0/0 AI-Contributed/UT: 104/104
YannByron
marked this pull request as ready for review
October 15, 2026 08:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
After #10572, empty Ray row-id results and metadata-only search could expose a different schema from normal reads. Build both output schemas with
read_arrow_schemaso they follow the same runtime contract.Align existing read expectations with that contract. The existing search fastpath-versus-lookup and Ray empty-versus-nonempty tests cover the two fixes; the existing native schema tests cover nullability and write constraints. Convert the BinaryRow read fixture once after setup writes, and retain strict value/schema comparisons and invalid-NULL write checks.
Also update the existing unsupported-cast case and nested MAP conversion for current core behavior. This addresses the independent master Native CI failures and contains no CWD changes from #10567.
Tests
git diff --checkpassed.