Repository navigation
[python] Fix the row filter on PyArrow 6 - #10557
Merged
Merged
Conversation
apache#10539 made FilterRecordBatchReader._filter_batch_by_row call RecordBatch.select, which PyArrow 6 does not have, so the Python 3.6 job fails test_append_only_reader_with_filter with "'RecordBatch' object has no attribute 'select'". Select the columns on the Table that the next line builds anyway; PyArrow 6 has Table.select.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
#10539 made
FilterRecordBatchReader._filter_batch_by_rowcallRecordBatch.select. PyArrow 6, which the Python 3.6 job installs, hasTable.selectbut notRecordBatch.select, so that job fails:For example, job 115681294594 of #10552. Master's Python jobs stopped at flake8 before #10552 fixed it, so this failure only showed up afterwards.
Master now fails the same way, for example job 116061121154 on b634373. #10572 contains the same change, but it is waiting for apache/paimon-rust#1128.
This pull request selects the columns on the
Tablethat the next line builds anyway.Tests
dev/cfg.inipasses.API and Format
No.
Documentation
No.