[flink] Fix flaky AppendTableITCase streaming compaction tests - #10184
Open
LuciferYang wants to merge 1 commit into
Open
LuciferYang wants to merge 1 commit into
LuciferYang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
AppendTableITCase.testCompactionInStreamingMode, and its siblingtestCompactionInStreamingModeWithMaxWatermark, are flaky. They poll for up to 60 s for aCOMPACTsnapshot from a streaming append pipeline, and under CI load the firstCOMPACTsnapshot occasionally arrives after the 60 s cut-off, so the test fails withTime up for streaming execute, don't get expected result.On a healthy run the snapshot lands in under 20 s: the streaming job starts, four small files accumulate at about one per second, the coordinator picks them up on its next discovery cycle, compaction runs, and the compacted snapshot commits. So 60 s is normally comfortable. The failure is a benign wall-clock race in job deployment and checkpoint/commit progress under CI contention, not the file-count gate. #1634 floated lowering
compaction.min.file-num, but that only trims the roughly 4 s accumulation phase and does not touch the part that actually stalls. Raising the wait to 5 minutes, the value the rest ofpaimon-flinkalready uses for generous waits, gives the rare tail room to finish while still failing on a genuine hang.This closes #10183, the same flake reported earlier in #1634.
Tests
No new tests. This only raises the
assertStreamingHasCompacttimeout from 60 s to 5 minutes in the threeAppendTableITCasecopies (paimon-flink-1.18,paimon-flink-1.19,paimon-flink-common); the behavior under test is unchanged.API and Format
No.
Documentation
No.