Repository navigation
feat(datafusion): support timestamp time travel for external engines - #1121
Merged
JingsongLi merged 1 commit intoOct 14, 2026
Merged
Conversation
plusplusjiajia
marked this pull request as ready for review
October 13, 2026 10:07
JingsongLi
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Support
TIMESTAMP AS OF '<yyyy-MM-dd HH:mm:ss>'for registered external table engines throughSQLContextand DataFusionSessionContext:The timestamp is parsed as for Paimon tables (local time zone, epoch milliseconds) and passed to the engine, which picks the snapshot.
Follow-up to #1113.
Brief change log
TableEngineResolver::resolve_table_at_timestamp. The default implementation rejects timestamp time travel, so existing resolvers keep failing closed.TIMESTAMP AS OFon external data tables through the same read-only wrapper and session option checks asVERSION AS OF.SQLContextresolves without loading the current provider; rawSessionContextpreloads it and propagates its errors; branches, metadata tables andFOR SYSTEM_TIME AS OFremain rejected.Tests
SQLContextreads a timestamp snapshot when the current provider cannot be resolved; rawSessionContextpropagates the current resolution error.