HDDS-15126. Remove unused TestHDDSUpgrade#10148
Open
errose28 wants to merge 2 commits intoapache:HDDS-14496-zdufrom
Open
HDDS-15126. Remove unused TestHDDSUpgrade#10148errose28 wants to merge 2 commits intoapache:HDDS-14496-zdufrom
errose28 wants to merge 2 commits intoapache:HDDS-14496-zdufrom
Conversation
errose28
added
the
zdu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TestHDDSUpgrade is not run in CI and has not been run in years. It takes extremely long to run and it enumerates a large amount of failure scenarios that are not representative of actual failure domains, especially now that finalization is going to be a single Ratis request. We should remove this test since it is not adding any value and we are not planning to update it for ZDU.
This PR also sets us up to remove all
UpgradeFinalizationExecutors. In the new versioning framework, these will not be required. After this PR they are only used within the old upgrade framework itself, so whenBasicUpgradeFinalizerand similar classes are removed, we can remove the finalization executors with them.What is the link to the Apache JIRA
HDDS-15126
How was this patch tested?
CI passing on my fork (one failure in ratis log parser is unrelated)