Skip to content

HDDS-14920. Check actions with zizmor#10102

Merged
errose28 merged 9 commits intoapache:masterfrom
adoroszlai:HDDS-14920
Apr 27, 2026
Merged

HDDS-14920. Check actions with zizmor#10102
errose28 merged 9 commits intoapache:masterfrom
adoroszlai:HDDS-14920

Conversation

@adoroszlai
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

  • Check GitHub workflows with zizmor.
  • Fix violations:
    • avoid template injection by using intermediate variables (see GitHub doc)
    • do not persist credentials
    • limit workflow permissions
    • pass specific secrets to reusable workflows
    • pin actions by SHA

Also fixes leftover Ratis property names (changed in pom.xml by HDDS-5410) in ci-with-ratis and flaky-test-check.

https://issues.apache.org/jira/browse/HDDS-14920

How was this patch tested?

@adoroszlai adoroszlai self-assigned this Apr 21, 2026
@adoroszlai adoroszlai added the CI label Apr 21, 2026
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copy link
Copy Markdown
Contributor

@errose28 errose28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this.

@errose28 errose28 merged commit bc54891 into apache:master Apr 27, 2026
94 of 95 checks passed
@adoroszlai adoroszlai deleted the HDDS-14920 branch April 28, 2026 05:31
@adoroszlai
Copy link
Copy Markdown
Contributor Author

Thanks @errose28 for the review. scheduled-label-pull-requests turns out to need more permissions, fixing it in #10150.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants