HDDS-15026. Introduce DevContainer to improve contributor experience#10075
HDDS-15026. Introduce DevContainer to improve contributor experience#10075peterxcli merged 1 commit intoapache:masterfrom
Conversation
|
Thanks @henrybear327 for the patch. Please link to relevant docs that describe devcontainers.
Can you please provide steps? |
Sorry for being too brief on this PR. I will make sure I include more context next time. The official website is https://containers.dev/ - "A development container (or dev container for short) allows you to use a container as a full-featured development environment. It can be used to run an application, to separate tools, libraries, or runtimes needed for working with a codebase, and to aid in continuous integration and testing." The main benefits are that developers can quickly spin up a Github Codespace and start working on the project, or, locally, a devcontainer, such that all toolchains required for developments are setup already. It's also used in a lot of Apache projects. Locally, I followed the devcontainer CLI guide here to install and spin up a devcontainer instance. On github, I created a codespace against this branch, as shown in the following image: For both environments, as Hope this helps. |
7c38d08 to
69cfb50
Compare
|
Thanks @henrybear327 for the detailed description. We should also add the new ozone/hadoop-ozone/dist/src/main/assemblies/ozone-src.xml Lines 70 to 76 in ea50306 |
9f97fa7 to
bd31c07
Compare
Done! :) Thanks! |
|
Gentle ping @peterxcli @adoroszlai for a final review :) Thank you! |
|
@henrybear327 LGTM, I'm waiting for @peterxcli to take a look |
peterxcli
left a comment
There was a problem hiding this comment.
other LGTM! can merge after comment is resolved.
|
Really appreciate and look forward to this change, as I’m a VS Code/Cursor user too. |
Glad it helped :) Please resolve the comment if you think the reply makes sense! Otherwise, I am happy to keep answering question until we are aligned! :) |
peterxcli
left a comment
There was a problem hiding this comment.
Thanks for the update! will merge after CI pass
|
Thanks @henrybear327 for the patch, @adoroszlai for the review! |
Thanks @peterxcli and @adoroszlai for the review and discussion! :) |


What changes were proposed in this pull request?
With devcontainer, the development environment can be setup quickly, locally and also on Github Codespace, which reduces friction for contributors to onboard.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15026
How was this patch tested?