HDDS-14896. Use separate container for clients in rolling-upgrade suite#10032
Merged
errose28 merged 11 commits intoapache:HDDS-14496-zdufrom Apr 27, 2026
Merged
HDDS-14896. Use separate container for clients in rolling-upgrade suite#10032errose28 merged 11 commits intoapache:HDDS-14496-zdufrom
errose28 merged 11 commits intoapache:HDDS-14496-zdufrom
Conversation
github-actions
Bot
added
the
zdu
Contributor
|
Thanks @dombizita for working on this. The change looks good, LGTM! |
Russole
approved these changes
Apr 5, 2026
errose28
reviewed
Apr 21, 2026
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
Thanks for adding this. Just a few comments, and there are merge conflicts since the last acceptance test change went in.
errose28
reviewed
Apr 24, 2026
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
LGTM, but there's a test failure in the networking. Not sure if it's intermittent.
--- RUNNING ROLLING UPGRADE TEST FROM 2.2.0 TO 2.2.0 ---
Using Docker Compose v2
--- SETTING UP OLD VERSION 2.2.0 ---
--- RUNNING WITH OLD VERSION 2.2.0 ---
Error response from daemon: failed to set up container networking: Address already in use
errose28
approved these changes
Apr 27, 2026
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
LGTM, thanks for the updates.
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Apr 27, 2026
* HDDS-14496-zdu: HDDS-14826. Prepare OM to switch from LayoutVersionManager to ComponentVersionManager (apache#10098) HDDS-14896. Use separate container for clients in rolling-upgrade suite (apache#10032) HDDS-15034. Query SCM status for ozone admin upgrade status command (apache#10084) HDDS-14897. Add multiple S3 gateways to the rolling-upgrade suite (apache#10028) hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMStorage.java hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestOMStorage.java hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/upgrade/TestOMUpgradeFinalizer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added a separate container for clients in rolling-upgrade suite, so a workaround can be removed, where we checked to not use for tests the SCM container which is currently restarted. To be able to run in an exact container the commands I added that parameter to the helper methods.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14896
How was this patch tested?
CI on my fork with running the rolling restart test: https://github.com/dombizita/ozone/actions/runs/23915743686