chore: add missing ASF license headers - #416
Merged
Merged
Conversation
Adds the standard ASF header to the source files that were added after the bulk header pass in July (PR 242) without one: - cli/internal/plugin/*.go (5 files) - converters/sigma/** Python sources, tests and pyproject.toml (15 files) - converters/nvidia/tests/fixtures/*.yaml (2 files) Header text and comment style follow the existing files in each directory. No functional change. Generated-by: Claude Code
jbonofre
self-requested a review
September 18, 2026 03:59
jbonofre
approved these changes
Sep 18, 2026
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bulk header pass in #242 (July) covered the tree at the time, but 22 source files added since then have no ASF header, and nothing in CI checks for it:
cli/internal/plugin/*.go(5 files, the plugin discovery and invoke code)converters/sigma/: the Python package, its tests andpyproject.toml(15 files)converters/nvidia/tests/fixtures/*.yaml(2 files)This adds the header to each, using the exact text and comment style of the neighbouring files (the Go files share the wrapping used in
cli/cmd/*.go, the Python, TOML and YAML files use the#form). Insertion only, no other change;git diff --statshows 22 files, +368, -0.The sigma and nvidia suites fail on this branch in the same three and two tests as on current main (
OssieDocumentand the generated document still expect thesemantic_modelwrapper removed in #383); #396 migrates them, and with #396 merged on top of this branch both suites pass in full (91 and 83). The cli suite passes.With the 0.3.0 source release being prepared, I've also started a thread on dev@ about whether a header-only check in CI is wanted, separate from the rest of #258. This PR stands on its own either way.
Written with LLM assistance for the file scan and the insertion script; I checked every file and the header text against its neighbours myself.
Related Issues
Relates to #242, #258, #396.
Checklist
Specification
core-spec/and follow the existing structureOntology
ontology/are consistent with spec changesConverters
converters/is updated to reflect spec or ontology changesValidation
validation/are updated if the spec changedDocumentation
docs/is updated to reflect any user-facing changesCONTRIBUTING.mdis updated if the contribution process changedExamples
examples/are added or updated for any new spec constructs or converter supportTests
pytest/ CI green)Compliance