-
Notifications
You must be signed in to change notification settings - Fork 278
Feat(ontology): add Ossie -> RelationalAI converter with formula parsing and reasoner #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vmihalovski
wants to merge
4
commits into
apache:main
Choose a base branch
from
vmihalovski:ossie-to-relationalai
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,4 +56,4 @@ htmlcov/ | |
| .idea/ | ||
| *.iml | ||
| *.iws | ||
| *.ipr | ||
| *.ipr | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
converters/ontology/src/ossie_ontology/converter/ossie_to_relationalai/__init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| """Ossie -> RelationalAI (PyRel) conversion. | ||
|
|
||
| Importing anything from this package imports `relationalai`, which ships as the | ||
| optional `relationalai` extra. Nothing under `ossie_ontology` imports this | ||
| package at module scope, so the rest of the library stays installable — and | ||
| importable — without the SDK present. | ||
|
|
||
| The model this converter targets is not here: `OntologyModel` and the rest of | ||
| the PyRel-side types live under `ossie_ontology.vendor.relationalai`, the same | ||
| way the Palantir model lives under `ossie_ontology.vendor.palantir`. What is | ||
| left here is the translation itself. | ||
| """ | ||
|
|
||
| from ossie_ontology.converter.ossie_to_relationalai.converter import ( | ||
| OssieToRelationalAIConverter, | ||
| TableProvider, | ||
| declared_table, | ||
| warehouse_table, | ||
| ) | ||
| from ossie_ontology.vendor.relationalai.ontology import OntologyModel | ||
|
|
||
| __all__ = [ | ||
| "OssieToRelationalAIConverter", | ||
| "OntologyModel", | ||
| # The dataset extension point: swap `table_provider` to read datasets from | ||
| # somewhere other than the warehouse their `source` names. | ||
| "TableProvider", | ||
| "warehouse_table", | ||
| "declared_table", | ||
| ] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package is non-free. This may require PMC approval (please see the PR checklist that you get when you open a new PR).
In my opinion, at the very least it should be clearly stated in the README that this is a fully proprietary package and what is its license (the PyPI listing does not say that). That matters because the license can be arbitrarily restrictive, so people installing this may unknowingly get into trouble.
Disclaimer: I'm not a lawyer, nor a PMC member.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ostrzyciel, this is a good point. I will update the README file and add links and additional information about RelationalAI.