Skip to content

tools/nxstyle: allow CPython API identifiers - #19944

Merged
xiaoxiang781216 merged 1 commit into
apache:masterfrom
raiden00pl:nxstyle-python
Aug 24, 2026
Merged

tools/nxstyle: allow CPython API identifiers#19944
xiaoxiang781216 merged 1 commit into
apache:masterfrom
raiden00pl:nxstyle-python

Conversation

@raiden00pl

Copy link
Copy Markdown
Member

Summary

CPython exposes mixed-case PyMem_* and PyOS_* names that applications cannot rename.

Impact

fix CI in apache/nuttx-apps#3746

Testing

CI

@github-actions github-actions Bot added Area: Tooling Size: XS The size of the change in this PR is very small labels Aug 24, 2026
@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

MemBrowse Memory Report

No memory changes detected for:

@xiaoxiang781216

Copy link
Copy Markdown
Contributor

@raiden00pl need this patch merge first to fix ci error:
https://github.com/apache/nuttx/actions/runs/32699693915/job/97348900849?pr=19944

@simbit18

simbit18 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

@xiaoxiang781216, it looks like some recently added PR have broken the jobs.

====================================================================================
Configuration/Tool: qemu-armv8a/nsh_smp
2026-08-24 07:15:37
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Building NuttX...
roundrobin.c: In function 'get_primes_thread':
Error: roundrobin.c:137:19: error: implicit declaration of function 'atomic_fetch_add'; did you mean 'atomic_fetch_add_4'? [-Werror=implicit-function-declaration]
  137 |       g_rr_values[atomic_fetch_add(&g_rr_value_index, 1)] = id;
      |                   ^~~~~~~~~~~~~~~~
      |                   atomic_fetch_add_4
cc1.exe: all warnings being treated as errors

PR #19867

@zhangyu-duck , please check

@zhangyu-duck

Copy link
Copy Markdown

we need this pr merge, please wait for little
apache/nuttx-apps#3733 (review)

@simbit18

CPython exposes mixed-case PyMem_* and PyOS_* names that applications cannot rename.

Signed-off-by: raiden00pl <raiden00@railab.me>
@xiaoxiang781216
xiaoxiang781216 merged commit 90b71fb into apache:master Aug 24, 2026
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Tooling Size: XS The size of the change in this PR is very small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants