Migrate to JDK 21 unix sockets - #9597
Open
mbien wants to merge 1 commit into
Open
Conversation
mbien
added
Code cleanup
mbien
force-pushed
the
unixsocket-cleanup
branch
from
September 3, 2026 21:45
4ae03b4 to
a682108
Compare
mbien
marked this pull request as ready for review
September 3, 2026 22:47
matthiasblaesing
requested changes
Sep 5, 2026
matthiasblaesing
left a comment
matthiasblaesing
left a comment
Contributor
There was a problem hiding this comment.
Upload of files in PHP projects still works without asking for passwords, so jsch works and agent integration is also active.
A terminal connection to a remote system was possible, so I suspect dlight is also happy.
The change to docker is breaking the module (suggestion for fix is in the inline comment).
If I understand this correctly: norrisjeremy/jsch@1cd3980 the jzlib libraries were integrated into jsch. We can drop the dependency of com.jcraft.jsch on com.jcraft.jzlib. ide/c.jcraft.jzlib is then a candatidate for removal.
- jsch lib update - and JDK 21 baseline allows kohlschutter-junixsocket removal - migrated docker.api to JDK api - fix BundleException by setting Bundle-ManifestVersion=2 - removed jzlib wrapper since it is now shipped with jsch - adjust module-auto-deps and other configs to the new situation Co-authored-by: =?UTF-8?q?Matthias=20Bl=C3=A4sing?= <mblaesing@doppel-helix.eu>
mbien
force-pushed
the
unixsocket-cleanup
branch
from
September 5, 2026 17:54
a682108 to
ab99234
Compare
Member
Author
|
removed jzlib and updated occurrences in
|
matthiasblaesing
approved these changes
Sep 6, 2026
matthiasblaesing
left a comment
matthiasblaesing
left a comment
Contributor
There was a problem hiding this comment.
Looks sane to me. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent felix / jgit cleanups should allow us to update jsch which was a blocker for removal of
ide/libs.c.kohlschutter.junixsocket. The secondary blocker was lack of lower bound JDK 21.This is also in context of #9594 (comment) which reminded me on this.
com.jcraft.jschis used innot well tested - testing help appreciated.