[MSHARED-895] PropertiesUtil closes streams it doesn't create

[jira-importer]

Elliotte Rusty Harold opened MSHARED-895 and commented

specifically the methods loadOptionalProperties(InputStream inputStream ) and loadProperties(InputStream inputStream )

 

see discussion on #41

---

1 votes, 2 watchers

[jira-importer]

Michael Osipov commented

The PR has been merged. Is this one addressed?

[jira-importer]

Elliotte Rusty Harold commented

No, that's just where this issue was first noticed. It's a tricky one to address because it will change behavior. That PR added a warning that behavior is likely to change in the future.

[slachiewicz]

Direction: the stream-closing behaviour stays as documented for the 3.x line. #424 tried to stop closing and was closed after review: the javadoc has promised the change "in a future release" for years, but consumers written against that promise are the ones who would leak, and nothing in the signature warns them. The change belongs to a major version, with the InputStream overloads either dropped or made non-closing at the same time.

The review of #424 also pointed at the larger defect: loadProperties(InputStream) and loadOptionalProperties(InputStream) swallow IOException and return empty properties, so an I/O failure is indistinguishable from an empty file. That is the part worth fixing first, and it is also a behaviour change, so it wants its own issue rather than riding on this one.

This comment was created with AI assistance.