[MSHARED-765] Password not escaped (on windows?)

[jira-importer]

Claus Näveke opened MSHARED-765 and commented

When using a password which contains the & character, the jarsigner plugin fails (in my case on windows), because the & is not escaped in the command line that is executed in background.

Workaround is to rewrite the password with ^& instead.

---

Affects: maven-jarsigner-1.4

Issue Links:

• MSHARED-851 & must trigger quoting in Windows

• MSHARED-832 Cannot invoke maven from path with parentheses on Windows

[jira-importer]

Sylwester Lachiewicz commented

We need a similar quotation functionality to org.apache.maven.shared.utils.cli.shell.BourneShell class but for Windows cmd.

Special is one of: &<>()@^|

[jira-importer]

Matthias Bünger commented

This project has moved from Jira to GitHub Issues. This issue was migrated to apache/maven-jarsigner#47. Please visit the GitHub issue to view further activity, add comments, or subscribe to receive notifications.

[slachiewicz]

Direction: fix in CmdShell, conditional on the cmd.exe /? special set, and #286's parentheses case is folded in here. #434 implements it: any executable or argument containing whitespace or one of & < > ( ) @ ^ | is double-quoted, items already quoted are left alone, and setQuotedArgumentsEnabled(false) opts out.

Two notes for anyone tracking this from maven-jarsigner or maven-invoker. The ^& workaround mentioned above will need to be removed once this ships, since ^ is literal inside quotes and the password would then arrive as ^&. And master currently lacks even the space quoting that 3.4.2 had, which ef89c5a removed; the PR restores that too.

This comment was created with AI assistance.