Skip to content

fix: correct 'Asserion.test_strings' typo in Response Assertion property name #6753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterWang wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −3
Open

fix: correct 'Asserion.test_strings' typo in Response Assertion property name #6753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/components/src/main/java/org/apache/jmeter/assertions/ResponseAssertion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ public class ResponseAssertion extends AbstractScopedAssertion implements Serial
private static final String REQUEST_HEADERS = "Assertion.request_headers"; // $NON-NLS-1$
private static final String REQUEST_DATA = "Assertion.request_data"; // $NON-NLS-1$
private static final String ASSUME_SUCCESS = "Assertion.assume_success"; // $NON-NLS-1$
private static final String TEST_STRINGS = "Asserion.test_strings"; // $NON-NLS-1$
private static final String TEST_STRINGS = "Assertion.test_strings"; // $NON-NLS-1$
private static final String TEST_STRINGS_LEGACY = "Asserion.test_strings"; // $NON-NLS-1$
private static final String TEST_TYPE = "Assertion.test_type"; // $NON-NLS-1$
private static final String CUSTOM_MESSAGE = "Assertion.custom_message"; // $NON-NLS-1$

Expand Down Expand Up @@ -219,7 +220,19 @@ public int getTestType() {
}

public CollectionProperty getTestStrings() {
return (CollectionProperty) getProperty(TEST_STRINGS);
CollectionProperty result = (CollectionProperty) getProperty(TEST_STRINGS);
if (result instanceof NullProperty) {
CollectionProperty legacy = (CollectionProperty) getProperty(TEST_STRINGS_LEGACY);
if (legacy instanceof NullProperty) {
return new CollectionProperty(TEST_STRINGS, new ArrayList<String>());
}
// Migrate the legacy (misspelled) property so it is persisted under the correctly spelled name
CollectionProperty migrated = new CollectionProperty(TEST_STRINGS, legacy);
setProperty(migrated);
removeProperty(TEST_STRINGS_LEGACY);
return migrated;
}
return result;
}

public boolean isEqualsType() {
Expand Down
2 changes: 1 addition & 1 deletion src/core/src/main/resources/org/apache/jmeter/gui/action/schematic.xsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ ul.tree li:last-child {
</xsl:choose>
</b>
[
<xsl:for-each select='collectionProp[@name="Asserion.test_strings"]/stringProp'>
<xsl:for-each select='collectionProp[@name="Assertion.test_strings"]/stringProp'>
"<xsl:value-of select='.'/>"
<xsl:if test="position() != last()">,</xsl:if>
</xsl:for-each>
Expand Down