JAMES-4210 Implement RFC 5034 AUTH command for POP3#3092
Merged
quantranhong1999 merged 13 commits intoJul 21, 2026
Conversation
chibenwa
reviewed
Jul 17, 2026
chibenwa
left a comment
chibenwa
left a comment
Contributor
There was a problem hiding this comment.
I'm happy to see comprehensive tests on thePOP3 layer covering real HTTP exchanges
However the sasl bridge design seems very boiler plate to me. That's not a hard blocker but I believe it holds room for simplification
Extract mailbox opening and INBOX provisioning into a reusable component shared by USER/PASS and AUTH.
Translate POP3 Base64 challenges and responses to shared SASL exchanges, including cancellation, final server data, and cleanup.
Implement AUTH parsing, transport availability checks, exchange lifecycle management, capability advertisement, and mailbox authentication.
Preserve regular POP3 and initial AUTH command limits while allowing bounded long SASL continuation responses.
Register AUTH, configure PASS through the PLAIN SASL policy, and require TLS for plaintext USER/PASS by default.
Load built-in and custom SASL factories with Guice and wire Spring to the default PLAIN and OAuth mechanisms.
Cover PLAIN and OAuth flows, STARTTLS capability changes, line limits, cancellation, cleanup, and TLS defaults.
Cover Guice mechanism configuration and distributed CAPA and AUTH PLAIN behavior.
Before: 2 min 10 sec After: 30 sec
quantranhong1999
force-pushed
the
sasl-pop3-support
branch
from
July 21, 2026 05:58
938d737 to
0e58e91
Compare
Member
Author
|
Rebased and reused the SaslCodec (drop POP3Bridge): 0e58e91 |
chibenwa
approved these changes
Jul 21, 2026
Arsnael
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So POP3 can leverage SASL mechanisms via the AUTH command, just like IMAP/SMTP.