[TDB-247] Wait for region leader election before region migration - #18699
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After a ConfigNode leader switch,
RemoveRegionPeerProcedurecan resume before the Region leader cache has been rebuilt.RegionMaintainHandlerconsults that cache while selecting a replica and transferring a Ratis leader. A missing or explicitly unknown entry can otherwise cause aNullPointerException, terminating the procedure before region removal completes.Centralize Region leader lookup in a helper that treats a missing or
-1entry as unknown, waits for the existingLoadManager.waitForRegionGroupReadyleader-election and priority-update cycle, and then reads the cache again. If the leader is still unavailable after the wait, the helper retains the-1fallback so the procedure can continue safely without dereferencingnull. Both replica selection and Ratis leader transfer use this lookup.Add regression coverage for DataRegions and SchemaRegions covering missing and unknown leaders, waiting and rereading the cache after election, avoiding an unnecessary wait for a known leader, successful transfer and cache updates, and a cache entry disappearing between lookups.
Validation
mvn -B -pl iotdb-core/confignode -Dtest=RegionMaintainHandlerTest,RegionMaintainHandlerConsensusPipeTest,RemoveRegionPeerProcedureTest,RegionMigrateProcedureTest -Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false test(28 tests passed)mvn -B spotless:apply -pl iotdb-core/confignodemvn -B test-compile -DskipTests -P with-zh-localeCluster failover integration testing was not run.
This PR has:
Key changed/added classes
RegionMaintainHandlerRegionMaintainHandlerTest