Conversation
| // inheritance test plan: | ||
| // - snapshot ID inheritance, not dv snapshot ID inheritance | ||
| // - file seq and data seq inheritance from null WITH ADDED | ||
| // - file seq and data seq not inherited with EXISTING, MODIFIED, DELETE (SHOULD FAIL?) |
Contributor
There was a problem hiding this comment.
For the column update case (and only specifically that case I think), we would want to inherhit data seq. number for the MODIFIED case. We don't have that write path anyways so I'm assuming this comment was just made in the context of this initial inheritance implementation, but just mentioning in case.
Contributor
Author
There was a problem hiding this comment.
I didn't mean to leave this in and I'll remove it. I just wanted to run the full test suite over the weekend.
rdblue
marked this pull request as draft
September 21, 2026 16:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements inheritance in
V4ManifestReader. This does not handlefirst_row_idassignment, which will be in a separate PR.v3 and earlier user
InheritableMetadataFactoryto set up inheritance that sets spec ID, snapshot ID, sequence number, and manifest location. This PR ensures the same fields are set:TrackingStruct#inherit(long, long)TrackingStruct#inherit(long, long)_file, similar to how_posis projected through readersThis removes
inheritFrom(Tracking)andsetManifestLocation. The first inheritance method didn't acceptManifestFileand is now simpler. It doesn't need to check manifest tracking fields consistency.setManifestLocationis not needed by using readers to set the_filefield.Test plan:
TestTrackingStruct. This is expanded to more cases using parameterized tests, not just specific statusesTestV4ManifestReaderverifies simple inheritance cases for each field, but full behavior tests are inTestTrackingStruct.