feat(kms): Add resolving KMS client factory - #3251
Draft
zakariya-s wants to merge 10 commits into
Draft
zakariya-s wants to merge 10 commits into
zakariya-s wants to merge 10 commits into
Conversation
# Conflicts: # Cargo.lock # Cargo.toml # README.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Adds
ResolvingKmsClientFactorytoiceberg-kms.The factory selects an enabled built-in KMS implementation using the
encryption.kms-typecatalog property. The fixedaws,azure, andgcpvalues follow Iceberg Java.Provider-specific configuration remains typed through methods such as
with_aws_factory. Custom KMS implementations ontinue to useCatalogBuilder::with_kms_client_factory, replacing Java’s reflection-basedencryption.kms-implmechanism.Like Java, the resolver rejects configurations containing both
encryption.kms-typeandencryption.kms-impl. The documentation also describes the current REST configuration initialization limitation.Are these changes tested?
Yes, unit tests.
AI Disclosure
LLMs were used for assistance.