Conversation
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
manuzhang
force-pushed
the
agent/add-parsed-snapshot-cache
branch
from
September 21, 2026 05:30
97b9847 to
c39ae81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SnapshotCachewrappers and scansFileIO-owned state without changingSnapshot's public layoutWhy
PR #875 avoids repeated storage reads for immutable metadata, but each new scan still reparses cached manifest-list bytes. This follow-up reuses the parsed
ManifestFileentries while the corresponding byte-cache entry remains alive.Parsed entries are not retained for oversized content that bypasses the byte cache, and failures are shared with current waiters without becoming permanent cached failures.
Dependency
Depends on #875. Until #875 merges, GitHub's comparison against
mainincludes the lower metadata-content-cache commit; the isolated change is commitd93c92c.Validation
pre-commit run --show-diff-on-failure --all-files