Skip to content

Replace usages of deprecated external APIs#15722

Merged
matrei merged 9 commits into
8.0.xfrom
remove-depr-warnings
Jun 26, 2026
Merged

Replace usages of deprecated external APIs#15722
matrei merged 9 commits into
8.0.xfrom
remove-depr-warnings

Conversation

@matrei

@matrei matrei commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Hibernate deprecations are excluded.

Hibernate deprecations are excluded.
@jdaugherty

Copy link
Copy Markdown
Contributor

This will cause a merge conflict with the step 2 PR - since it evolves on top of the hibernate 7 changes. I think we should merge that before this for that reason.

matrei added 5 commits June 9, 2026 08:23
# Conflicts:
#	grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/GrailsDomainBinder.java
#	grails-data-hibernate7/spring-orm/src/main/java/org/grails/orm/hibernate/support/hibernate7/HibernateOperations.java
#	grails-gsp/grails-sitemesh3/src/main/java/org/grails/plugins/sitemesh3/Sitemesh3EnvironmentPostProcessor.java
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 30.43478% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.3419%. Comparing base (0a334c8) to head (4fbd843).

Files with missing lines Patch % Lines
...roovy/grails/web/databinding/DataBindingUtils.java 0.0000% 5 Missing ⚠️
...ransform/internal/DelegateAsyncTransformation.java 42.8571% 2 Missing and 2 partials ⚠️
.../src/main/groovy/grails/util/GrailsClassUtils.java 0.0000% 4 Missing ⚠️
...apper/src/main/java/grails/init/GrailsUpdater.java 0.0000% 4 Missing ⚠️
...n/groovy/org/grails/io/watch/DirectoryWatcher.java 33.3333% 2 Missing ⚠️
...groovy/org/grails/plugins/DefaultGrailsPlugin.java 0.0000% 2 Missing ⚠️
...g/grails/orm/hibernate/cfg/GrailsDomainBinder.java 50.0000% 2 Missing ⚠️
...ore/mapping/services/DefaultServiceDefinition.java 0.0000% 2 Missing ⚠️
...main/groovy/org/grails/cli/util/ResourceUtils.java 0.0000% 2 Missing ⚠️
...groovy/org/grails/web/mapping/RegexUrlMapping.java 0.0000% 0 Missing and 2 partials ⚠️
... and 19 more
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##                8.0.x     #15722        +/-   ##
==================================================
+ Coverage     49.2583%   49.3419%   +0.0836%     
- Complexity      16506      16518        +12     
==================================================
  Files            1941       1941                
  Lines           92023      92009        -14     
  Branches        16062      16055         -7     
==================================================
+ Hits            45329      45399        +70     
+ Misses          39649      39551        -98     
- Partials         7045       7059        +14     
Files with missing lines Coverage Δ
...roovy/org/grails/web/converters/ConverterUtil.java 23.0769% <100.0000%> (ø)
...ails-core/src/main/groovy/grails/util/Holders.java 73.0337% <100.0000%> (+3.1412%) ⬆️
.../core/util/BeanCreationProfilingPostProcessor.java 0.0000% <ø> (ø)
.../groovy/org/grails/plugins/BinaryGrailsPlugin.java 35.9375% <100.0000%> (ø)
...te/support/hibernate5/ConfigurableJtaPlatform.java 0.0000% <ø> (ø)
...pport/hibernate5/HibernateExceptionTranslator.java 0.0000% <ø> (ø)
...ate/support/hibernate5/HibernateJdbcException.java 0.0000% <ø> (ø)
...ate5/HibernateObjectRetrievalFailureException.java 0.0000% <ø> (ø)
...te/support/hibernate5/HibernateQueryException.java 0.0000% <ø> (ø)
...e/support/hibernate5/HibernateSystemException.java 50.0000% <ø> (ø)
... and 48 more

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codeconsole codeconsole left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

Comment thread grails-shell-cli/src/main/groovy/org/grails/cli/util/ResourceUtils.java Outdated
@bito-code-review

Copy link
Copy Markdown

The catch block you mentioned is not present in the provided PR diff. The diff only contains changes to DelegateAsyncTransformation.java and DelegateAsyncSpec.groovy. Since the file grails-shell-cli/src/main/groovy/org/grails/cli/util/ResourceUtils.java is not part of this pull request, I cannot analyze or comment on that specific code change.

@testlens-app

testlens-app Bot commented Jun 26, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: 2b7a267
▶️ Tests: 47492 executed
⚪️ Checks: 46/46 completed


Learn more about TestLens at testlens.app.

@matrei matrei merged commit 009180c into 8.0.x Jun 26, 2026
47 checks passed
@matrei matrei deleted the remove-depr-warnings branch June 26, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants