Conversation
Add libxml2 to the velox feature in dev/vcpkg/vcpkg.json so Gluten's static (vcpkg) builds provision it explicitly. Velox's Spark XPath functions resolve libxml2 via find_package(LibXml2). Providing it through Gluten's own vcpkg manifest (rather than Velox's shared setup scripts) follows the pattern used for other Spark-consumer dependencies. libxml2 is already used by cpp/velox and cpp/bolt and pulled transitively for ABFS via azure-storage-common-cpp; this makes it a first-class, deterministic dependency. It resolves to 2.15.1 through the existing builtin-baseline, so no overrides pin is required. Generated-by: GitHub Copilot CLI (Claude Opus 4.8) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The manifest change is scoped, well-formed, and has no unresolved review issues.
Review effort: Lite
Findings: None
What changed in this PR
Adds libxml2 to the Velox vcpkg feature for deterministic XPath support in static builds.
Changes:
- Declares
libxml2as a Velox dependency. - Uses the existing vcpkg baseline for version resolution.
| File | Description |
|---|---|
dev/vcpkg/vcpkg.json |
Adds the libxml2 vcpkg dependency. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
libxml2to theveloxfeature indev/vcpkg/vcpkg.jsonso Gluten's static (vcpkg) builds provision it explicitly.Velox's Spark XPath functions resolve libxml2 via
find_package(LibXml2). Providing it through Gluten's own vcpkg manifest (rather than Velox's shared setup scripts) follows the pattern used for other Spark-consumer dependencies. libxml2 is already used bycpp/veloxandcpp/bolt, and pulled transitively for ABFS viaazure-storage-common-cpp; this makes it a first-class, deterministic dependency. It resolves to 2.15.1 through the existingbuiltin-baseline, so nooverridespin is required.How was this patch tested?
Manifest-only change validated as well-formed JSON. Exercised by the existing vcpkg-based native CI build.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: GitHub Copilot CLI (Claude Opus 4.8)