[rust] Stale out-of-order responses can incorrectly reset the idempotent writer - #4252
Open
naivedogger wants to merge 2 commits into
Open
[rust] Stale out-of-order responses can incorrectly reset the idempotent writer#4252naivedogger wants to merge 2 commits into
naivedogger wants to merge 2 commits into
Conversation
Track each batch's last acknowledged sequence at send time and refresh it on every attempt. Retry out-of-order responses when acknowledgement progress has advanced, while preserving genuine-error resets. Add Sender regression tests for stale responses, genuine errors, and snapshot refresh on retry, following the Java fix in apache#4125. Fixes apache#4238
Contributor
Author
|
@platinumhamburg @loserwang1024 could you please take a look when convenient? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #4238
Brief change log
Tests
API and Format
Documentation