[rust] Return error for out-of-range server API versions - #4244
Open
slfan1989 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #4241
ServerApiVersions::new()converted theapi_key,min_version, andmax_versionfields received from the server fromi32toi16usingunwrap().An out-of-range value in the server's
ApiVersionsResponsecould therefore panic the Rust client during connection establishment.This change makes invalid server API version values return a descriptive error instead of causing a panic.
Brief change log
ServerApiVersions::new()to returnResult<ServerApiVersions, Error>.unwrap()calls with checked conversions.api_keymin_versionmax_versionTests
Manually ran the unit tests.
API and Format
No.
Documentation
No.