Conversation
…lators ResultTypeQueryable describes an aggregate function's output, not its accumulator. Use the existing generic extraction path for the accumulator while preserving explicit output type hints and missing-type handling. Generated-by: OpenAI Codex (GPT-6)
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix FLINK-36139. For an
AggregateFunction<String, Long, Row>implementingResultTypeQueryable<Row>, accumulator type extraction currently returns the declaredRowresult type instead ofLong. This selects an incompatible serializer for the accumulator.This is a draft while Jira assignment and maintainer agreement are pending.
Brief change log
ResultTypeQueryableonly when extracting theAggregateFunctionaccumulator type; retain the existing generic extraction and input inference.Verifying this change
TypeExtractorTestpassed../mvnw -B -ntp -pl flink-core -am -Dflink.forkCountUnitTest=1 clean verifypassed on Temurin 17.0.20.1 with Maven Wrapper 3.9.16. The local run used a separate Maven settings file prioritizing Maven Central. Across the selected modules, JUnit XML reports contain 8,321 tests, zero failures/errors, and 1,777 skipped cases.The original Kubernetes resubmission/checkpoint scenario and the full Flink repository test suite were not run locally.
Does this pull request potentially affect one of the following parts:
@PublicEvolvingtype-extraction method; no signatures or annotations change.Documentation
Was generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex (GPT-6)