Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request addresses
FLINK-32509.
InputStreamFSInputWrapper.seek(long)currently relies onInputStream.skip(long)to move forward. TheInputStreamcontract allowsskip()to return zero, including at EOF, so seeking beyond the stream canloop forever. Some implementations can also report a positive skip beyond the
actual EOF, allowing the wrapper to accept an unreachable position.
This change makes forward seek consume bytes through a bounded buffer and
throw
EOFExceptionwhen the requested position cannot be reached.Brief change log
InputStream.skip()in forward seek with bounded read-and-discardoperations.
EOF, and successful forward seek across the buffer boundary.
Verifying this change
This change added tests and can be verified as follows:
InputStreamFSInputWrapperTestcovers normal forward seek, zero-progress EOF,and a stream that reports skip progress beyond its real end.
FileInputFormatTestcovers the closest existing caller behavior../mvnw -pl flink-core -am -DskipITs -Dtest=InputStreamFSInputWrapperTest,FileInputFormatTest -Dsurefire.failIfNoSpecifiedTests=false testpasses 36 tests with no failures, errors, or skips.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): nocomponents), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
Documentation
Was generative AI tooling used to co-author this PR?
Generated-by: