Skip to content

[BP-2.3][FLINK-40683][table] Assert materialized data in the anti-join-on-nested semantic test - #29241

Open
MartijnVisser wants to merge 1 commit into
apache:release-2.3from
MartijnVisser:FLINK-40683-2.3
Open

MartijnVisser wants to merge 1 commit into
apache:release-2.3from
MartijnVisser:FLINK-40683-2.3

Conversation

@MartijnVisser

Copy link
Copy Markdown
Contributor

What is the purpose of the change

  • JoinSemanticTests[anti-join-on-nested] asserts the raw changelog, so it fails whenever the
    anti join transiently emits and retracts +I[test_same]. It failed 11 of the 16 release-2.3
    nightlies between 2026-09-10 and 2026-09-17 (8 on Azure, 8 on GitHub Actions) and the push run
    of e10aab797f (https://github.com/apache/flink/actions/runs/35220462243)

Brief change log

  • The anti-join-on-nested sink asserts the materialized result instead of the raw changelog,
    like the other program in the file
  • Not a cherry-pick: master got the line from FLINK-39695 (4f8b4a88b1e), which also copies
    Calcite classes into the planner and does not belong on a patch branch
  • The companion PR makes the same change on release-2.2; release-1.20 does not have this test

Verifying this change

This change is already covered by existing tests, such as JoinSemanticTests.

  • each variant compiled once with ./mvnw -o -pl flink-table/flink-table-planner test -Dtest=JoinSemanticTests, then looped with surefire:test, JDK 17, under CPU
    load: 21 of 103 runs failed on cf7fbd3317d, 0 of 100 with this commit applied
  • changing NOT EXISTS to EXISTS makes the patched test fail, so the assertion still catches a
    regression

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Claude Code (Claude Opus 5)

…ted semantic test

The sink asserted the raw changelog, so the test failed on the transient
+I[test_same] and -D[test_same] that the anti join emits when the probe row
arrives before the build row. Master has asserted the materialized result for
this program since FLINK-39695, which is master-only.

Generated-by: Claude Code (Claude Opus 5)
@flinkbot

flinkbot commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@github-actions github-actions Bot added the community-reviewed PR has been reviewed by the community. label Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community. target:release-2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants