Conversation
Generated-by: Codex (GPT-5)
Collaborator
Author
|
Hi @snuyanzin, apologies for the unsolicited ping. I noticed that you recently reviewed filesystem connector path-handling work such as #27553. Would you mind taking a quick look at this approach and, if it seems appropriate, helping assign FLINK-6417? Unlike the earlier #15436, this PR implements glob handling in the default FileSource enumerators, preserves non-glob behavior, and uses only the generic FileSystem API. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request resolves FLINK-6417 for
FileSourceby allowing its default file enumerators to accept glob patterns in input paths. This makes it possible to select partition directories and files without constructing every concrete path in user code.The implementation is file-system independent. It traverses from the longest non-glob path prefix and reuses Flink's existing
GlobFilePathFilter, rather than changing a specific file system implementation or the semantics ofFileSystem#listStatus.Brief change log
NonSplittingRecursiveEnumerator, which is also inherited byBlockSplittingRecursiveEnumerator.*,?, and character classes in any path segment.Verifying this change
This change added tests covering:
?and character class patterns;The complete
flink-connector-filestest suite passes locally: 211 tests run, 0 failures, 0 errors, 6 skipped.Does this pull request potentially affect one of the following parts:
@Public(Evolving): yes (behavior and JavaDocs only; no signature changes)Documentation
Was generative AI tooling used to co-author this PR?
Generated-by: Codex (GPT-5)