Conversation
Collaborator
Contributor
|
@damjad One of the commits has Coauthor-by: AI tag can you squash the commits and add disclosure as per AI guidelines. |
damjad
force-pushed
the
fix/flink-model-triton-tensor-names
branch
from
September 16, 2026 20:29
77d46e2 to
23f8279
Compare
…e requests. Triton's KServe V2 protocol treats tensor names as case-sensitive. The previous implementation called inputName.toUpperCase() and outputName.toUpperCase() when building the inference request, causing HTTP 400 errors for any model whose config.pbtxt declared lowercase tensor names (e.g. 'input', 'output'). Remove the toUpperCase() calls so tensor names are sent exactly as declared in the model schema. Add TritonTensorNameCasingTest with two MockWebServer-backed tests that capture the outgoing HTTP request and assert the name fields in inputs and outputs preserve their original casing. Generated-by: Claude Sonnet 4.6 <noreply@anthropic.com>
damjad
force-pushed
the
fix/flink-model-triton-tensor-names
branch
from
September 16, 2026 20:32
23f8279 to
eabadbc
Compare
Contributor
Author
|
@spuru9 updated. |
Contributor
Author
|
@featzhang tagging you for visibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Triton Inference Server's KServe V2 protocol treats tensor names as case-sensitive. A model
configured with
input/outputtensors in itsconfig.pbtxtrejects requests that sendINPUT/OUTPUT, returning HTTP 400unexpected inference output 'OUTPUT'.TritonInferenceModelFunction.buildInferenceRequest()unconditionally uppercased both tensor names:This caused every request to a model with lowercase tensor names to fail at the network layer.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
Documentation
No public API or configuration changes. The fix aligns behaviour with the KServe V2 specification,
which defines tensor names as opaque strings whose casing is determined by the model's
config.pbtxt
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Sonnet 4.6 noreply@anthropic.com