[FLINK-40682][tests] Fix unstable ArchivedExecutionGraphTest - #29208
Open
SEPURI-SAI-KRISHNA wants to merge 1 commit into
Open
SEPURI-SAI-KRISHNA wants to merge 1 commit into
SEPURI-SAI-KRISHNA wants to merge 1 commit into
Conversation
Generated-by: Claude Code (Opus 5)
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
ArchivedExecutionGraphTestsometimes errors in@BeforeAllwithBUG: trying to schedule a region which is not in CREATED state. The scheduler runs onforMainThread()but gets a real future executor, soExecution#deploy()hands back to the main-thread executor from that executor's thread and the thread assertion throws. Normally that error is lost in the future chain. When the test thread attacheswhenCompleteAsyncafter it, the callback runs inline, fails v1 with theAssertionError, and the job cancels the regionsstartScheduling()has not reached yet. The CI log of the failing run shows v1 going from DEPLOYING to FAILED withjava.lang.AssertionErrorright before the error.Brief change log
DirectScheduledExecutorService, so the deployment callbacks run inline on the test thread. The extension still shuts it down. FLINK-38536 used the same executor forFinalizeOnMasterTestandExecutionGraphFinishTest.Verifying this change
deploy()delayed beforewhenCompleteAsync, the old test fails every run with the CI error (12 of 12), and the new test passes every run (5 of 5) with no main thread violations.ArchivedExecutionGraph#createFromstill failstestArchive.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5)