FINERACT-2777: Remove obsolete dead code block in TellerWritePlatformServiceJpaImpl.java - #6308
Open
DhroovSankla wants to merge 1 commit into
Open
Conversation
…ServiceJpaImpl Signed-off-by: Dhroov Sankla <dhroovsankla2004@gmail.com>
Aman-Mittal
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request resolves FINERACT-2777 by removing an obsolete, commented-out dead code block and its related
TODOcomment fromTellerWritePlatformServiceJpaImpl.java.The removed block (previously at lines 358–380) was a non-functional draft intended to check entity existence (loan accounts, savings accounts, and clients) but was never implemented. Removing it reduces technical debt, cleans up code smell, and improves readability of the teller transaction service.
Impact
Organisationmodule.Verifications
./gradlew spotlessApply./gradlew :fineract-provider:compileJava :fineract-provider:checkstyleMain