FINERACT-2771: Tax - User should be able to set end date for a tax group - #6292
Open
rymghosn wants to merge 1 commit into
Open
FINERACT-2771: Tax - User should be able to set end date for a tax group#6292rymghosn wants to merge 1 commit into
rymghosn wants to merge 1 commit into
Conversation
A tax group component's end date could only ever be set once: any attempt to change it to a different value after it had already been set was rejected outright, even when the new date was a valid future date. Removed that restriction so an end date can be updated repeatedly, as long as each new value remains after the component's start date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tax group component's end date could only ever be set once:
TaxValidator.validateTaxGroupEndDateAndTaxComponent()rejected any attempt to change an end date to a different value if it had
already been set before, even when the new value was a perfectly valid
future date after the component's start date. This made it impossible to
correct or extend an end date once entered.
This PR removes that one-time restriction. An existing tax group
component's end date can now be updated repeatedly, with the only remaining
constraint being that each new end date must fall after the component's
start date.
PR:(https://issues.apache.org/jira/browse/FINERACT-2771)