FINERACT-2770: Tax - Unable to edit a tax group - #6291
Open
rymghosn wants to merge 1 commit into
Open
Conversation
rymghosn
force-pushed
the
port/CBS-87-tax-group-component-id-enddate
branch
from
August 19, 2026 10:58
48efccc to
ce2636e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TaxGroupComponent(the request DTO used byPOST /v1/taxes/groupandPUT /v1/taxes/group/{taxGroupId}) was missing theidandendDatefields — it only declared
taxComponentIdandstartDate.TaxGroupApiResource#createTaxGroup/#updateTaxGroupdeserialize theincoming JSON request body into this DTO and then re-serialize it before
handing it off to the command handler. Because the DTO didn't declare
id/endDate, Jackson silently dropped those values during thatround-trip for any client that submitted them — before the tax group's
write-platform service or validators ever saw them. In practice this made
it impossible to correctly update an existing tax group's components (e.g.
resubmitting an existing component's
id, or setting/keeping itsendDate).This is a pre-existing mismatch between the DTO and its own documented
contract:
TaxGroupApiResource's Swagger docs already statefor tax group creation — the DTO just never actually had the
id/endDatefields to back that documentation.
Fix
Add the missing
idandendDatefields toTaxGroupComponent, matchingwhat the API already documents and what
TaxGroupData/response-sidemapping already expects.
PR:(https://issues.apache.org/jira/browse/FINERACT-2770)