FINERACT-2765: Tax Component and Tax Group names should be unique - #6286
Open
rymghosn wants to merge 1 commit into
Open
FINERACT-2765: Tax Component and Tax Group names should be unique#6286rymghosn wants to merge 1 commit into
rymghosn wants to merge 1 commit into
Conversation
rymghosn
force-pushed
the
port/CBS-203-tax-name-uniqueness
branch
from
August 19, 2026 11:17
771a07a to
86b4814
Compare
Reject creating or renaming a tax component/tax group to a name that already exists, and reject a tax group submission that references the same tax component more than once.
rymghosn
force-pushed
the
port/CBS-203-tax-name-uniqueness
branch
from
August 20, 2026 06:49
86b4814 to
1b5e89c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently nothing prevents creating a
TaxComponentorTaxGroupwith aname that's already in use, or renaming one to collide with another. This
also allowed submitting a
TaxGroupwith the same tax component listedmore than once in its
taxComponentsarray.This PR adds:
component already has the given
name(case-sensitive match againstTaxComponentRepository.findByName, relying on DB collation for exactmatching), returning
tax.component.name.must.be.unique.already has the given
name(case-insensitive, viaTaxGroupRepository.existsByNameIgnoreCase/existsByNameIgnoreCaseAndIdNot), returningtax.group.name.must.be.unique.taxComponentspayload thatreferences the same
taxComponentIdmore than once, returningvalidation.msg.tax.group.duplicate.component.Update checks only trigger when the
name(or, for groups, a componentlist) is actually being changed, so updates that leave the name untouched
are unaffected.
PR (https://issues.apache.org/jira/browse/FINERACT-2765).