FINERACT-2764: Loan tax is only deducted on disbursement - #6285
Open
rymghosn wants to merge 1 commit into
Open
Conversation
rymghosn
force-pushed
the
port/CBS-336-loan-tax-on-non-disbursement-charges
branch
from
August 18, 2026 14:53
874e4f8 to
6eb733f
Compare
…bursement Extend tax-inclusive charge amount calculation (TaxUtils.calculateChargeAmountWithTax) to loan charge payment paths that were bypassing it: charge payment via account transfer, scheduled fee transfer jobs, repayment-at-disbursement charge handling, and disbursement-linked-account charge transfers. Previously tax was only applied at loan disbursement time; charges paid on a specific date or via repayment had their tax component silently dropped.
rymghosn
force-pushed
the
port/CBS-336-loan-tax-on-non-disbursement-charges
branch
from
August 19, 2026 11:38
6eb733f to
52d485e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tax configured on a loan charge (via a tax group) was only being applied when the charge was collected at disbursement. When a charge was instead
paid on its own due date, on repayment, or transferred from a linked savings account by the scheduled fee job, the tax component was silently
dropped and only the pre-tax base amount was charged/transferred.
This PR makes tax calculation consistent across all loan-charge payment paths by applying TaxUtils.calculateChargeAmountWithTax(...) wherever a
charge amount is finalized for payment or transfer:
fees) from a linked savings account, wired with a new LoanChargeRepository dependency to look up the charge's tax group
considered applicable for a given transaction date); no change to existing tax math
TaxUtils.calculateChargeAmountWithTax(...) itself already existed and was already in use for disbursement charges and savings-account charges —
this PR extends its use to the loan-charge-payment paths that were bypassing it.
PR:(https://issues.apache.org/jira/browse/FINERACT-2764)