feat(brush): add circle brush support (resolves #21738) - #21760
Open
vinay-kumar-0 wants to merge 1 commit into
Open
vinay-kumar-0 wants to merge 1 commit into
vinay-kumar-0 wants to merge 1 commit into
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Adds a new 'circle' brush type to the toolbox, allowing users to select data points within a circular area.
Fixed issues
#21738
Details
Before: What was the problem?
The brush component previously only supported rectangular (rect) and polygonal (polygon) selections. There was no native tool for selecting data points using a circular radius, which limited proximity-based data analysis and selection.
After: How does it behave after the fixing?
Users can now activate the 'circle' brush from the toolbox.
Implemented Euclidean squared distance hit-testing in selector.ts for points, and rectangle-circle collision detection for bounding boxes.
Registered the circle coordinate convertors in BrushTargetManager.ts.
Added the necessary SVG path and UI integration in BrushController.ts and Brush.ts.
Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
Tested locally using test/brush.html by verifying data point selection, sum calculations in the sidebar, and toolbar integration.
Merging options
Other information