branch-4.1: [Improvement](join) add HashCRC32Return32 and make join_hash_table use 32-bit hash value #62512#62813
Open
github-actions[bot] wants to merge 1 commit intobranch-4.1from
Open
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
…e 32-bit hash value (#62512) ``` after: - InitProbeSideTime: 85.747ms - ProbeIntermediateRows: 85.52771M (85527710) before: - InitProbeSideTime: 102.746ms - ProbeIntermediateRows: 85.52771M (85527710) ``` This pull request introduces a new CRC32-based hashing implementation that consistently returns a 32-bit hash value, and updates the join hash table infrastructure to use this new implementation for primary, fixed, and string key types. The changes are focused on improving hash consistency and efficiency by leveraging type-specific CRC32 intrinsics. The most important changes are: ### New CRC32 Hash Implementation * Added a new header file `hash_crc32_return32.h` that implements type-specialized CRC32 hash functions returning `uint32_t`, using the narrowest possible intrinsic for each type and supporting a wide range of key types including arithmetic, 128/256-bit, and compound types. ### Hash Table Infrastructure Updates * Updated the hash type used in `JoinHashTable` and related hash table context typedefs to use the new `HashCRC32Return32` instead of the previous `HashCRC32`, ensuring all hash values are consistently 32 bits. [[1]](diffhunk://#diff-50a41f44edcbb4571a6e14c6440f7a53fdd2e68f1c95dc51fa1fc906610db5f3L43-R43) [[2]](diffhunk://#diff-253e23eff6f1a66e419e353770f4d0cb9fbdaa804f254f15ced17119840e7a77L74-R88) ### Build and Include Adjustments * Included the new `hash_crc32_return32.h` header in `join_utils.h` to make the new hash function available to the relevant code.
Contributor
|
run buildall |
morningman
force-pushed
the
auto-pick-62512-branch-4.1
branch
from
168699d to
118c136
Compare
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #62512