[fix](iceberg) Decouple JDBC catalog metadata name#62806
Open
suxiaogang223 wants to merge 1 commit intoapache:masterfrom
Open
[fix](iceberg) Decouple JDBC catalog metadata name#62806suxiaogang223 wants to merge 1 commit intoapache:masterfrom
suxiaogang223 wants to merge 1 commit intoapache:masterfrom
Conversation
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary: Doris initialized Iceberg JDBC Catalog with the Doris local catalog name, which also controls the catalog_name isolation key in Iceberg JDBC metadata tables. This made Doris unable to read metadata written under a different Iceberg JDBC catalog_name, such as Spark's catalog name.
### Release note
Add required iceberg.jdbc.catalog_name for Iceberg JDBC catalog to decouple Doris local catalog name from the Iceberg JDBC metadata catalog_name.
### Check List (For Author)
- Test: Unit Test
- ./run-fe-ut.sh --run org.apache.doris.datasource.property.metastore.IcebergJdbcMetaStorePropertiesTest
- Regression test not run per request; updated test_iceberg_jdbc_catalog to use a custom Doris catalog name with iceberg.jdbc.catalog_name.
- Behavior changed: Yes. Iceberg JDBC catalog now requires iceberg.jdbc.catalog_name and uses it as the SDK catalog name while preserving the Doris local catalog name.
- Does this need documentation: Yes (follow-up docs can describe the new required catalog property).
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #59502
Problem Summary:
Doris initialized Iceberg JDBC Catalog with the Doris local catalog name. Iceberg JDBC Catalog uses the SDK catalog initialization name as the
catalog_nameisolation key in JDBC metadata tables, so a Doris catalog named differently from the writer catalog, such as Sparkspark_catalog, could not list namespaces or tables written under that remotecatalog_name.This PR adds required
iceberg.jdbc.catalog_namefor Iceberg JDBC catalog and uses it as the Iceberg SDK catalog initialization name. The Doris local catalog name remains independent and continues to be used for Doris namespace/table identifier semantics.Release note
Add required
iceberg.jdbc.catalog_namefor Iceberg JDBC catalog to specify the remote Iceberg JDBC metadatacatalog_name.Check List (For Author)
Test
./run-fe-ut.sh --run org.apache.doris.datasource.property.metastore.IcebergJdbcMetaStorePropertiesTestBehavior changed:
iceberg.jdbc.catalog_name, and Doris uses it as the Iceberg JDBC metadata catalog isolation name instead of reusing the Doris local catalog name.Does this need documentation?
Check List (For Reviewer who merge this PR)