fix(gh-copilot): trim enterprise/organization slugs to fix connection validation failure - #9071
Open
bujjibabukatta wants to merge 1 commit into
Open
fix(gh-copilot): trim enterprise/organization slugs to fix connection validation failure#9071bujjibabukatta wants to merge 1 commit into
bujjibabukatta wants to merge 1 commit into
Conversation
… validation failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8991 — GitHub Copilot connector's "Test Connection" fails with
either enterprise or organization is required even when a valid Enterprise
Slug is filled in and Organization is left blank.
Root Cause
validateConnection() checked Organization for emptiness without trimming
it, while HasEnterprise() already trimmed Enterprise. This mismatch meant
a slug with incidental whitespace (e.g. copy/pasted from GitHub) could be
treated as "present" in one check and "empty" in another. A second, separate
copy of this same check in connection_test_helper.go also had a different
error message, showing the two had drifted out of sync.
The frontend's IConnectionAPI/IConnection types were also missing the
enterprise field, and the test/testOld API payload types didn't
include it either — a type-safety gap worth closing alongside this fix.
Fix
JSON decode path (hyphenated slug, whitespace-only org)