Skip to content

Object identity construction - #134

Open
mboapache wants to merge 2 commits into
mainfrom
ObjectIdentityConstruction
Open

mboapache wants to merge 2 commits into
mainfrom
ObjectIdentityConstruction

Conversation

@mboapache

Copy link
Copy Markdown
Contributor

Identity-key construction gated on an allowlist; Class.forName no longer initializes unvetted classes

@sonarqubecloud

Copy link
Copy Markdown

@clr-apache

Copy link
Copy Markdown
Contributor

I do not believe that we need a new constant to allow arbitrary classes to be used as ObjectIdentity.
We can simplify this by allowing the standard identity classes that are shipped with JDO or a user-specified object identity class named in the metadata.

@mboapache

mboapache commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author

I agree with Craig's commet. Altough it is a backward compatibility issue to remove support for arbitrary classes to be used as ObjectIdentity, I also think this is not a problem in practice. People will use classes like LongIdentity or StringIdentity or come up with their own ObjectId class and then there is no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants