Skip to content

Uncomment debug in Cargo.toml - #27261

Merged
gabotechs merged 3 commits into
mainfrom
gabotechs/uncomment-debug-in-cargo.toml
Nov 10, 2026
Merged

gabotechs merged 3 commits into
mainfrom
gabotechs/uncomment-debug-in-cargo.toml

Conversation

@gabotechs

Copy link
Copy Markdown
Contributor

Important

Fork CI setup: For pull requests from a fork to main, enable workflows in your fork's Actions tab before you push.
See the fork CI setup guide.

Which issue does this PR close?

  • Closes #.

Rationale for this change

Just reverts an incidental change from #26155.

What changes are included in this PR?

Uncommenting one intentionally committed line

What is the testing strategy for this PR?

Just a Cargo.toml change

Are there any user-facing changes?

No

@codecov-commenter

codecov-commenter commented Nov 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.55%. Comparing base (6e0e0da) to head (fcd86f9).
⚠️ Report is 6 commits behind head on main.

Flag Coverage Δ
all-tests 83.55% <ø> (+0.21%) ⬆️
sqllogictests 61.29% <ø> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@            Coverage Diff             @@
##             main   #27261      +/-   ##
==========================================
+ Coverage   83.34%   83.55%   +0.21%     
==========================================
  Files        1173     1173              
  Lines      479350   485203    +5853     
  Branches   479350   485203    +5853     
==========================================
+ Hits       399501   405407    +5906     
+ Misses      55428    55380      -48     
+ Partials    24421    24416       -5     

see 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pepijnve

pepijnve commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

I had committed this change accidentally. 👍 for quickly reverting back to what was there.

Doesn't have to be part of this PR, but I'm wondering if a second "interactive development" profile would be useful since stripping most debug information makes interactive debugging unusable. Or perhaps have the 'fast for ai' profile be a dedicated one that the agent is instructed to prefer over 'dev' via agenst.md?

@gabotechs

Copy link
Copy Markdown
Contributor Author

Just did some investigation about what other big Rust open-source projects do:

So it looks to me that adding a second profile specific for debugging is actually a good idea, something like:

[profile.dbg] 
inherits = "dev"
debug = true

I can add it here 👍

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@2010YOUY01 2010YOUY01 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you!

Comment thread Cargo.toml Resolved
@gabotechs
gabotechs enabled auto-merge November 10, 2026 06:32
@gabotechs
gabotechs added this pull request to the merge queue Nov 10, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 10, 2026
@gabotechs
gabotechs added this pull request to the merge queue Nov 10, 2026
Merged via the queue into main with commit 9e0a08f Nov 10, 2026
78 checks passed
@gabotechs
gabotechs deleted the gabotechs/uncomment-debug-in-cargo.toml branch November 10, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants