Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25299 +/- ##
==========================================
- Coverage 81.91% 81.91% -0.01%
==========================================
Files 1134 1134
Lines 425703 425878 +175
Branches 425703 425878 +175
==========================================
+ Hits 348725 348848 +123
- Misses 56300 56342 +42
- Partials 20678 20688 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
DataFrame::with_columnonly adds anExpr. Appending anArrayReftoday means collecting the frame, concatenating columns, and callingread_batch. That executes the plan just to change the schema. Related #9672This PR adds a lazy API for that case: the array is stored on the plan and attached when the new
DataFrameruns. No collect at the call site.What changes are included in this PR?
DataFrame::with_array_columns- same shape asfrom_columns(name +ArrayRef).AddColumnProvider(TableProvider) wraps the currentLogicalPlanand the new columns.AddColumnExec(ExecutionPlan) zips each input batch witharray.slice(offset, n)at execution time.What is the testing strategy for this PR?
Yes. Tests cover:
Are there any user-facing changes?
Yes - new
DataFrame::with_array_columnsmethod. Not a breaking change. Docs and an example are included.