perf: Optimize translate to use new bulk-NULL string builders#22171
Open
neilconway wants to merge 3 commits into
Open
perf: Optimize translate to use new bulk-NULL string builders#22171neilconway wants to merge 3 commits into
translate to use new bulk-NULL string builders#22171neilconway wants to merge 3 commits into
Conversation
Contributor
Author
|
run benchmark translate |
|
🤖 Criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing neilc/perf-translate-builder (2dcbd5b) to 18a219c (merge-base) diff File an issue against this benchmark runner |
|
🤖 Criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
translateusingappend_with#22170.Rationale for this change
This PR refactors and optimizes the
translateUDF. In particular, we switch to using the new bulk-NULL string builders, avoiding per-row NULL computation, and avoid an intermediate string copy by usingappend_with/append_byte_map.Benchmarks (Arm64):
Scalar (scalar_from_to)
Array — ASCII (array_from_to)
Array — non-ASCII (array_from_to_non_ascii)
What changes are included in this PR?
NullBuffer::union_manyappend_withandappend_byte_maprather thanappend_value, which avoids an intermediate scratch bufferTranslationTableenumfrom/to, Unicode strings" caseAre these changes tested?
Yes; new test added.
Are there any user-facing changes?
No.